Thomas Robitaille
Thomas Robitaille
I agree with this!
@keflavich - ok, that's useful feedback, thanks! If we want to go that route, then the best approach might actually be to modify the astropy WCSLIB wrapper code in C...
Or of course we could simply add all those properties onto the class I have in this PR but it's a lot of properties to add and I'm a bit...
Close in favor of https://github.com/astropy/astropy/pull/18338
The background for the current architecture is given in https://github.com/astropy/regions/issues/107 and this was implemented in https://github.com/astropy/regions/pull/132. The current architecture mirrors how DS9 defines regions, where regions defined in world coordinates...
It might make sense to try and implement or at least scope out support for all regions from the start, to make sure the proposed format will actually work with...
What if we thought about this as a new mixin column type which would be a column of regions in a table? (So then format is secondary as @keflavich says)
I'm not super keen on having an auto mode because it's usually good to be specific about whether one expects abi3 wheels or not, otherwise a package could silently start...
Thank you for working on this! I can help review this in September once I am back at work 😊
@sedonaprice - I should have time to review this next week, could you rebase though to resolve the conflict?