Ary Borenszweig comments

Results 414 comments of


                                            Ary Borenszweig

default trait implementations resolve functions relative to trait impl instead of trait definition

I wrote a bit about a way to implementing this properly [here](https://github.com/noir-lang/noir/pull/8637#issuecomment-2904575386), but I'll write it here too because this is the actual issue. I think the problem right now...

default trait implementations resolve functions relative to trait impl instead of trait definition

Another code that doesn't compile because of this (from #7086): ```noir pub struct Reader { data: [Field; N], index: u32, } impl Reader { fn new(data: [Field; N]) -> Self...

Cannot use type aliases in paths

To be able to work on this we first need to implement #6000. The reason is that we can solve the alias but it solves to a type that has...

[RFC] Rename `StaticArray#to_slice` to `StaticArray#to_unsafe_slice`

> I think the use of slice should be categorized in the same frame as Pointer No, Slice is totally safe. The problem is returning a slice that points to...

LSP goto def should error when Ident at Location could not resolve

I don't think this issue is valid anymore as the code for this changed a lot and I can't find a place where something is returning `None`.

Error writing file: Broken pipe (IO::Error)

Could it be that the server is writing the response but the client already closed the connection? I'll try to reproduce that scenario...

Error writing file: Broken pipe (IO::Error)

@waj are you able to see the errors? See #9067

Struct is not considered as "used" despite being passed as a generic when constructing another type.

Maybe for now we can avoid issuing an error if the struct doesn't have any fields?

Struct is not considered as "used" despite being passed as a generic when constructing another type.

Or `#[allow(dead_code)]` on a struct in cases where the compiler can't catch these cases.

Support specifying generics on a type when calling an associated function

I think this is a duplicate of #5584 I added support for parsing the turbofishes in the middle of paths but implementing this particular case is kind of tricky.