Andre Asselin

Results 19 comments of Andre Asselin

The changes look good to me, but I'm not doing any gulp-based projects at the moment, so I can't test them.

Updated an existing test to reliably repro the issue. In debugging, there are a couple of problems I'm seeing: 1. es.wait (https://github.com/jonkemp/gulp-useref/blob/master/lib/streamManager.js#L175) is not waiting for both streams to finish....

OK, I'll take a look at the updated code and see if I can reproduce the issue.

@LinusBorg See https://github.com/vuejs-templates/webpack/issues/200#issuecomment-255557630 I haven't personally tested it, but @mixedCase claims there's no issue running with vue-router in history mode and assetsPublicPath set to './'.

@LinusBorg I can give it a test, but I don't think it will break, because the font's URL is relative to the CSS file-- assuming you can load the CSS...

I tested with vue-router history mode, and it worked fine, no issues. @LinusBorg, would it be possible to merge this one please?

@LinusBorg When I tested history mode with relative paths, I didn't run into any issues, including reloading on a subroute. Note that for dev, I left the assetsPublicPath as '/',...

@LinusBorg Gentle reminder, when you have time, to upload your GH repo. Thanks!

@LinusBorg Apologies for taking so long to get back on this one (client work!). I just sent you a PR to the repo you sent me above. I think the...

I ran a simple test on the latest template with code splitting and setting `assetsPublicPath` to './', and everything seems to work fine. Take a look at https://github.com/asselin/vue-webpack-codesplit-test. Does this...