Assaf Admi

Results 77 comments of Assaf Admi

@avlitman Hi, can you PTAL?

> @assafad since the issue is "two or more different virt-controllers are reporting the kubevirt_vmi_migration_succeeded metric for the same migration (VMIM)", I wonder if this is something fixable by #12165...

> I think you may have pasted the wrong issue Here it is - https://issues.redhat.com/browse/CNV-40981 (from the PR description). > But why is the new virt-controller pod reporting that migration...

@machadovilaca we can probably fix this issue only by adding a `For: 1h` to the alert, and then for temporary metrics duplications, it won't fire. But deciding on the time...

> kubevirt_vmi_migration_succeeded is reported by a collector, remember we discussing if collectors should only be registered by the leader for the work in https://github.com/kubevirt/kubevirt/pull/12165? Do you think multiple pods might...

/cc @machadovilaca, @enp0s3, @sradco

> shouldn't the collector only be executed by the leader pod? right now they are executed in all replicas, but they should report the same value, right? it makes sense...