Assaf Admi

Results 48 comments of Assaf Admi

@machadovilaca I think `pull-kubevirt-e2e-k8s-1.29-sig-compute` is failing because of the PR changes. Seems related to `kubevirt_vmi_vcpu_seconds_total` metric.

Since the monitoring refactoring is still WIP (should be completed by https://github.com/kubevirt/kubevirt/pull/11184 and https://issues.redhat.com/browse/CNV-39013), currently the monitoring linter gives: ``` monitoringlinter ./pkg/... /root/go/src/kubevirt.io/kubevirt/pkg/monitoring/client/prometheus/prometheus.go:95:2: monitoring-linter: metrics should be registered only within...

> Hi Assaf, I think in general we're trying to get rid of `tests/utils.go`. We don't want to add new functions there, but in your case you're just changing it....

@enp0s3 can you please take a look?