Anthony Sottile

Results 862 comments of Anthony Sottile

I have only a tiny bit of an idea of what I'm doing. I didn't bother writing tests. but it does seem to work nicely in my text editor :)...

I've edited the template into the original message -- if you could fill it out and then message back that would be great!

hi! thanks for the contribution but I'm actually removing this list in favor of a smaller, more manually-curated list of tools -- see #978 for more details

just the docker based ones, everything else should work

`pass_filenames: false` is usually wrong and results in always running everything always

hi! thanks for the contribution but I'm actually removing this list in favor of a smaller, more manually-curated list of tools -- see #978 for more details

the other branch which tried to solve this is here and my recommendation: https://github.com/pre-commit/pre-commit/pull/3259#issuecomment-2237682433

pretty sure in json mode it does a better job of obscuring the nonsense

I don't think pytest should automatically clean up any of a user's resources as it's arguably a correctness problem with the test suite or user code

yeah I'm fine with a better error message -- somehow notify the user that they're reassigning globals to `sys.std*` streams as a test side-effect