Anthony Sottile

Results 862 comments of Anthony Sottile

this branch was legitimately uncovered but was masked by a broken windows build https://github.com/pre-commit/pre-commit/blob/50c217964b0f00e38d67cac858b597501a86e22b/pre_commit/languages/rust.py#L99 when the build was fixed Linux had 100% coverage and windows was missing a branch --...

is there an actual case where this came up? feels a bit like garbage-in-garbage-out

I took a hacky stab at this in #270

dumb-init is not really supported on macos, the error indicates you're missing the wheel package (or a compatible version of setuptools)

mixins with side-effects are usually a smell, and I think this is not an exception here -- what if you have two levels of "abstract" you'd have to mixin the...

I'd rather just say "play stupid games win stupid prizes" -- putting square brackets in directory names imo clearly falls into that category

are you maybe using a very very old version of pre-commit and running `pre-commit install`? the error message indicates that .git/hooks/pre-commit got copied to .git/hooks/pre-commit.legacy _somehow_ pre-commit itself wouldn't do...

if it happens again -- can you check the contents of `.git/hooks`? additionally -- what are the contents in your vanilla dev container? do you have that image?

hmm do you happen to have the poetry lock that contains the pre-commit version (just so I can run exactly what you're running)

coming back to this now -- I'm able to build the docker image and if I add a git repo and `pre-commit install` in it then it seems to work...