Antti Sonkeri

Results 9 comments of Antti Sonkeri

As documented in #396, Bruno supports JSON with comments in the request body whether they are part of JSON spec or not.

This works fine with unquoted variables e.g. `"hello": {{var}}` but fails when variables are inside quotes like `"hello": "{{var}}"`. The quoted variable case gets turned into `"hello": ""dummyValue0""` which json-bigint...

The example in the issue description does not send the comments anymore, but the issue still occurs when the variable in the request body is not quoted. With quotes: ![image](https://github.com/usebruno/bruno/assets/19153764/d026053b-0b52-46b3-aea8-f06ee04ae421)...

> The is fantastic! Happy to get this feature into Bruno. A bit held up with the PR backlog, Will review this in the next 2 weeks. Great! Let me...

@tlaloc911 those additions look fine to me. However, I feel this PR is already quite big and I'd like to keep it to a relatively limited initial set of request...

@helloanoop @anusree-bruno @lohit-bruno Wondering who I should ping to get this reviewed and merged. One year anniversary for this PR is approaching 😅

> Hi @asonkeri , > > We definitely want to get this in — thank you for your patience, and also for the gentle reminder 😅 > > We're currently...

Just realized #3853 implemented styles for skipped requests. I guess this feature should also use that instead of just not running the requests like it does now. Maybe that's another...

Yeah, you are probably right. The current method of just sort of silently dropping the filtered requests has just felt somehow rough to me 😅