Alan Somers

Results 656 comments of Alan Somers

> [@asomers](https://github.com/asomers) can you release a new version with these changes? Yes! I'm just hoping to finish #649 first.

> @asomers I think the nightly is failing because some sort of new lints unrelated to this PR, would you like me to fix those also here? It's already fixed...

> @asomers There's already a changelog entry, let me know if you would like another sentence. Of course you did. But yesterday I was only viewing "changes since your last...

This is really a duplicate of #602 . I can easily fix it; however that will break one other user's use case. Sadly, I think I'll have to do that....

In your test program, do you expect that `get_num` will be called by another C function, or by a Rust function?

But in the example, you showed mocking `get_num`, not `do_something`. How are you getting multiple definition errors of functions that you haven't mocked?

The definitions look correct to me, but they're awfully obscure. These constants are so obscure that there's a risk of them being deemed unstable private APIs. That's why I generally...

nack @tgross35 there's an error for armv7. I'll open a PR to fix it.

> As I see, in most of cases (I've spotted only one different) when you are taking `db_rwlock`, you also take `db_mtx`. It makes no sense to me, unless the...

Though I see your comments, @amotin , I still struggle to understand the right thing to do, generally, because the locking requirements aren't well documented, nor are they enforced either...