Alan Somers

Results 656 comments of Alan Somers

> > One one hand it seems to make sense that if everyone is going to have to manually implement PartialEq themselves, then maybe we should just reduce the effort...

Extra unused fields might be unhelpful when implementing certain traits, but how could they make it unsafe? And shouldn't the compiler be able to handle unaligned fields?

What features are you building with? And what version of libc ?

I'll ask again: what version of libc are you using?

Hi Goran! I think you're close, but you should use `ioctl_write!` instead of `ioctl_readwrite!`. That affects the calculation of the second argument of `ioctl`.

@devnexen do you know why this test fails on Ubuntu 22.04, or can you figure out?

The problem is that a Unix `Timespec` can't represent times greater than `i64::MAX` seconds. Saturating the conversion would be bad, because then subtracting two `TimeSpec`s that were produced by `TimeSpec::from_duration`...

> What about transitioning towards this impl over some time? I could prepare PRs for adding `TryFrom` and once this is released the successor for deprecating `From` so that other...

@sbellon your dataset probably really is corrupted. But it would be good to be sure. This is the first I've heard of this type of corruption happening at any other...

The fact that `ls -al` can trigger the problem suggests that you have a corrupt directory, not a regular file. If plain `ls` works but `ls -al` does not, then...