André Mello

That seems to fix it. I wonder how/when this broke down.

To make sure I got this: calling `task.cancel()` will asynchronously awake the task with a `CancelledError`. The cancellation point will be an `await` instance, since that is where the task...

> Having the conditional inside the loop is problematic for performance. That's very true, but how often does it actually matter? If you're iterating over something with known length, odds...

> I actually think the more compelling case for this is when you want to not do something for the last item on the iterator. That's a good point, I...

> I'm generally not a fan of anything like this > > > ```rust > > for (i, elem) in elements.iter().enumerate() { > > do_something(elem); > > if elements.is_last_index(i) {...

> I don't find string joining like this compelling, because the easiest fix for this is to rotate the loop slightly: skip the space on the _first_ iteration instead of...

I want to hear more opinions still, but perhaps to proactively keep the discussion useful, I think there's a couple of fundamental things we should also keep in mind: *...

> [`Enumerate` is double-ended when the inner iterator is DoubleEnded+ExactSize](https://doc.rust-lang.org/std/iter/struct.Enumerate.html#impl-DoubleEndedIterator-for-Enumerate%3CI%3E). And `.rev()` is still lazy -- it just makes calling `next` call `next_back` and vice versa -- so `.rev().enumerate().rev()` is...

Ok, Phil redirected me here from the discussion in #5246. In summary, I also have a JMS578 device that required disabling UAS to work properly. I did so with a...