Alec Smecher

Results 173 comments of Alec Smecher
trafficstars

@librariam, I'm not sure about the admin history of the sandbox, but here's the template that comes up for me: ![image](https://user-images.githubusercontent.com/200411/114791748-dd845280-9d3b-11eb-86f7-26ab5ac57050.png)

IMO it's important that the reviewer be the one to accept/decline the invitation, rather than letting the editor do it on their behalf. I would favour something that reverts a...

Excellent work, @touhidurabir, and thanks for the assist, @NateWr!

Looks good to me, @withanage -- please merge and port forward to `stable-3_3_0`, `stable-3_3_1`, and `main`.

PR: https://github.com/pkp/pkp-lib/pull/9526 @Vitaliy-1, could you review this? Thanks!

Thanks, @aaabulafiaaa, and my apologies for the delay in reviewing this! Just a couple of adjustments to make before it's ready to merge.

Note that any solution that relies on request headers to determine the protocol will need to consider URL generation from command-line tools e.g. when a CRON job sends off review...

> Jumping to a different approach... why "force_ssl" is not forcing the protocol in getProtocol()? The `force_ssl` setting is checked in an authorization policy written in `PKPHandler`: https://github.com/pkp/pkp-lib/blob/stable-3_3_0/classes/handler/PKPHandler.inc.php#L275..L279 If `force_ssl`...

@touhidurabir, I checked with the Technical Committee, and they didn't raise any problems with bumping our PHP base to 8.2 for OJS/OMP/OPS 3.5. They're primarily familiar with RHEL (EPEL) and...

Thanks, @jyhein! It looks like the tests are not yet passing, but in any case, please let us know when you're ready for a review of the code.