Lonnie Liu

Results 64 comments of Lonnie Liu

gazelle also does not emit non-zero exit value on other type of errors, like when having errors on running `go get`: ```` $ gazelle update gazelle: finding module path for...

Just read some gazelle code; it is actually non-trivial to fix. The interfaces gazelle using generally does not return an error. For example: https://github.com/bazelbuild/bazel-gazelle/blob/41b542f9b0fefe916a95ca5460458abf916f5fe5/resolve/index.go#L61 which where the error is being...

maybe consider splitting this PR to smaller ones? is that possible?

@jjyao could you get some one from core team to review? @maxliuofficial maybe sync your branch with latest master head.

isn't it easier to just add the `depends_on` for steps? rather than breaking it down into pieces?

> I tried having it depends on the block step but that didn't really work. why? that is how it supposed to work?

> When I unblocked the step, the mac sanity check steps didn't even run or wait for agent .. they were just stuck there you need to add an empty...

this builds and passes on premerge, but when compiling locally, it says errors like this: ```` File 'ExprNodes.py', line 7478, in _create_unbound_cmethod_entry: AttributeNode(_raylet.pyx:4563:64, attribute = 'Nil', initialized_check = True, is_attribute...

```` Error compiling Cython file: ------------------------------------------------------------ ... cdef store_task_outputs(self, worker, outputs, const CAddress &caller_address, c_vector[c_pair[CObjectID, shared_ptr[CRayObject]]] *returns, CObjectID ref_generator_id=CObjectID.Nil()): ^ ------------------------------------------------------------ python/ray/_raylet.pyx:4563:64: Compiler crash in AnalyseExpressionsTransform File 'Nodes.py', line 397,...

seems that I need to stick with 0.29.x