Aslak Hellesøy

Results 268 comments of Aslak Hellesøy

I think we should encourage Markdown rather than “Markdown embedded in Gherkin”. The real thing rather than this weird thing. The JavaScript implementation has a rough [Markdown tokenizer](https://github.com/cucumber/common/blob/main/gherkin/javascript/src/GherkinInMarkdownTokenMatcher.ts). We could...

That’s great to hear @fullstackwebdev! Apart from you and me, I haven’t heard of anyone else using it. I don’t even think anyone on the core team is using it...

> in that case should we be discouraging the usage of markdown we see in the wild? It depends on what people are using to render feature files. Different tools...

@nddipiazza @jamietanna I'd welcome your feedback/review on this.

Yes, I'm aware it's still incomplete and buggy (which is why I made a draft PR). But what do you think of the general approach of using a stack that...

Testing with a ton of files is useful, but I think we can get pretty good confidence/coverage by modifying this test: https://github.com/cucumber/common/blob/main/gherkin-utils/javascript/test/walkGherkinDocumentTest.ts I'd suggest adding comments like ``` # 1...

Consider there two feature files: ```gherkin Feature: Background: Given foo Scenario: empty ``` ```gherkin Feature: Scenario: not empty Given foo ``` The first one should be `undefined` and the second...

Hi @mattwynne The compiler is pretty simple, [compiler.rb](https://github.com/cucumber/cucumber/blob/master/gherkin/ruby/lib/gherkin/pickles/compiler.rb) is less than 200 LOC. It doesn't have unit tests, though - only [approval tests](https://github.com/cucumber/cucumber/tree/master/gherkin/testdata/good) (the `.pickles.ndjson` files). I would start with...