Anton Korobeynikov

Results 791 comments of Anton Korobeynikov

> > Any smallest chance to get irgen fixes reviewed? @rjmccall @aschwaighofer @tkremenek @DougGregor ? > > I’m looking to see if we can get a review soon. Thanks a...

> The IRGen changes look good to me. Thanks!

@nikic Will you please take a look content-wise? Thanks!

@Poseydon42 Will you please update the post with all recent suggestions so it will be possible to schedule it on next Monday?

Will check it, thanks. At very least we'd need: - Tests - Manual And ensure that `R CMD check` passes

Let's view on the problem from slightly broader scope. Currently there is no set of P4 files that comprehensively cover all the aspects of the spec: the ones in `p4c/testdata/p4_16_samples`...

> I agree with everything you wrote :-) > My first quick reaction for this issue is "it seems like a reasonable choice to update the spec examples to match...