Anton Korobeynikov
Anton Korobeynikov
So, there are two issues here: 1. Tofino backend is using C sources in C++ mode 2. Somehow PCH generation conflicts with PIE codegen. This seems to depend on the...
> Iirc if you do not enable this on clang this will cause linking issues with protobuf. I haven't found a better solution than enabling it for all CMake targets....
> Sanitizers is failing. Let's see whether it throws an error after compilation. I would be happy to remove this. Yes, need to see what is wrong, but likely unrelated.
@fruffy clang bug wrt `__builtin_bit_cast` and PCH: https://github.com/llvm/llvm-project/commit/95d7ccb70b9cbd53f1f137c0b2411852c42c122b It seems to be fixed in clang 11. The CI is using very old clang 10. Is it possible to upgrade? :)
Actually, I think we need to discuss if we'd want to enable PCH by default: - It definitely speeds up clean rebuild - However, it interferes with ccache or other...
So, I disabled PCHs by default for now. Looks like there are some tradeoffs wrt ccache, so one needs to decide what might be preferable. Alternatively, we can have PCHs...
> Thanks for the work! I am actually a little confused why we have this conflict with ccache. Shouldn't the headers stay the same? Headers are the same, indeed. However,...
@swift-ci please test
preset=buildbot,tools=RA,stdlib=DA @swift-ci test with preset macOS
@aschwaighofer @rjmccall ping