Anton Korobeynikov
Anton Korobeynikov
> When does a visitor need to be copied, for example? First case when we're adding `Visitor` to `PassManager` via const reference. The second case is the default implementation of...
> When we were first moving to using GC, I assumed that the garbage collector's malloc would be very efficient (as it just needs to bump a pointer), so the...
> Intuitively I would say a PassManager should own any visitor passed to it. I can't think of a sensible scenario where a visitor is copied into a pass manager...
> Ah, I definitely have used this pattern before. Although I question whether doing that within a PassManager is a good idea. The VisitorRef implementation seems a little muddy, especially...
@grg Thanks! Do you use `visitAgain` / `visitOnce`?
> We might want to comment some use cases for these things which are there for downstream tools' benefit. Yeah. It would be great to have some test coverage as...
> > There's a much improved midend def-use pass in Intel's code that I had intended to "promote" to open source, but never got around to it before I left...
IMO, explicit "disable" should always be honored. I guess for warnings we need to have a tri-state: - enabled - disabled - promoted to error
> Do you mean even for message types that are originally errors? Or only for message types that are originally warning/info and get promoted to error via `-Werror`? For only...
@fruffy Does it support loop?