André Silva

Results 37 comments of André Silva

> This seems good to me, but I want to make sure we're not putting anything into the SDK that we'll need to change soon. I know there's been some...

@beeme1mr, @toddbaert, @kinyoklion, and @kylejuliandev, I made a couple of changes since your last review. Please look to see if they make sense.

> Should this DI extension method be within the existing [OpenFeature.Contrib.Providers.Flagd](https://www.nuget.org/packages/OpenFeature.Contrib.Providers.Flagd/) package? or within a seperate one? Please include it in the same package. Could be under `OpenFeature.Contrib.Flagd.DependencyInjection`.

I prefer the property initialisation approach, especially since we are configuring and not adding any extra service.

I believe this is ready for a RC. 👍

> @askpt I would suggest using https://pkg.go.dev/go.opentelemetry.io/contrib/exporters/autoexport and not re-implement the entire otel sdk. Thank you so much for the suggestion @erka! I was not aware of this library, and...

> @askpt I've resolved the FOSSA issues. @beeme1mr Is there any library i shouldn't be using? I think they are all related to OTEL.

> Hi @askpt To maintain consistency, should nullable enforcement and warnings-as-errors be enabled for test projects too, or is it preferred to apply these only to the source components? Yes....

> Ill look at your suggestions in the weekend. In the meantime, do you think the default values are reasonable/ too low / too high?? @hoerup they seem like reasonable...

> @askpt @kylejuliandev I’ve made all the requested changes. I only left out the README.md. If that’s OK, I’ll handle it in a separate ticket. Please review again. > >...