dotnet-sdk-contrib icon indicating copy to clipboard operation
dotnet-sdk-contrib copied to clipboard
verified publisher icon open-feature

feat: Add caching to GoFeatureFlag provider

Open hoerup opened this issue 7 months ago • 7 comments

This PR

Add caching to GoFeatureFlag provider

Related Issues

Fixes https://github.com/thomaspoignant/go-feature-flag/issues/657

Notes

Follow-up Tasks

How to test

hoerup avatar Apr 29 '25 21:04 hoerup

@thomaspoignant could you take a look ?

hoerup avatar May 01 '25 07:05 hoerup

Ill look at your suggestions in the weekend. In the meantime, do you think the default values are reasonable/ too low / too high??

hoerup avatar May 02 '25 16:05 hoerup

Ill look at your suggestions in the weekend. In the meantime, do you think the default values are reasonable/ too low / too high??

@hoerup they seem like reasonable values. Also, they are default so the consumer can tune the way they prefer.

askpt avatar May 02 '25 17:05 askpt

another thing: Currently I use the entire EvaluationContext as part of the cache key - is that how you'd expect it or should I only use the targetingKey bit ?

hoerup avatar May 03 '25 08:05 hoerup

@askpt could you take another look ?

hoerup avatar May 03 '25 15:05 hoerup

@askpt I think I have addressed all comments now

hoerup avatar May 07 '25 08:05 hoerup

@thomaspoignant just saw that you are working on a in-process evaluation thing - should we abort this cache PR in favor of the new feature ?

hoerup avatar May 12 '25 08:05 hoerup

@thomaspoignant just saw that you are working on a in-process evaluation thing - should we abort this cache PR in favor of the new feature ?

@thomaspoignant when ever you got the time, i'd really appreciate your input on this

hoerup avatar May 26 '25 02:05 hoerup

superseeded by https://github.com/open-feature/dotnet-sdk-contrib/pull/433

hoerup avatar Sep 18 '25 16:09 hoerup