Gilles Robert

Results 22 comments of Gilles Robert

@wittwerch https://github.com/opentracing-contrib/java-spring-web/pull/100 should fix your issue automatically in the next release ๐Ÿ™‚

Hi @pavolloffay Any update on this? I'd like to be able to trace messages using Spring amqp/RabbitTemplate Thank you!

@gytis @pavolloffay Looking at io.opentracing.contrib.spring.integration.messaging.OpenTracingChannelInterceptor, it instruments org.springframework.messaging.MessageChannel which is not used by org.springframework.amqp.rabbit.core.RabbitTemplate. I think a "traced" implementation of org.springframework.amqp.core.AmqpTemplate would be needed?

Hi @gytis and @pavolloffay, I'd like to contribute on the rabbitMq instrumentation. Should this happen in the opentracing-spring-messaging repo or somewhere else?

Thanks @gytis , that's also the way I saw it.

@pavolloffay https://github.com/opentracing-contrib/java-spring-cloud/pull/126 is ready for review :)

RabbitMQ instrumentation is located here. https://github.com/opentracing-contrib/java-spring-rabbitmq Its starter has been integrated here https://github.com/opentracing-contrib/java-spring-cloud/pull/158

Hi there @maciejwalkowiak @spencergibb , Could be fun, Iโ€™m in too!

@TYsemyn This issue is not specific to datasource metrics, itโ€™s the case for all the registered metrics in the meterregistry. (See second use case for hibernate stats) Regarding the ds,...

Valid point taken, but IMO, having discrepancies between the metrics and the real values is still not acceptable and we should find a way to fix it. ๐Ÿ™‚