Ashwin Agrawal

@zxuejing @kainwen if all the comments of the PR is addressed, please can we merge the same?

Seems @adam8157 the conclusion from the PR discussion is code change is not helping. I am with you we can revisit based on complaints instead of speculating the behavior now....

I feel only if we received complaints from the field we should touch this area else let's not proactively change any behavior.

Checksum errors mostly flags hardware/disk issues as its calculated right before writing data to disk and verified right after reading data from disk. Do you get this error both on...

> @Nirali13 Maybe we need a tool to dig out all these references, so the exceptions can be reported. Agree. We need to have some kind of python linter to...

We in general run with fsync off during testing as demo cluster is created with fsync off, do we need to do more?

This [1] message states per file `fsync()` is not needed even in production mode and should be removed. For reference found this was implemented via ``` commit 522baf14847a7e4cc97c49c7b1c28d21bc33921f Author: Michael...

Would be helpful for reviewers to clarify what exactly was the problem earlier and what changed in DTM that avoids problem now? Yes will need to dig through the history....

Just notes for future reference - I would like `postgresql.auto.conf` to stay as internal server specific config file and not touched by entities/utilities possibly outside database - One option could...

In general yes we do wish to get away from usage of dbid in tablespace paths, mainly due to - usage of it required us to modify `pg_basebackup` and `pg_rewind`...