gpdb icon indicating copy to clipboard operation
gpdb copied to clipboard

Published 20 hours ago • verified publisher icon greenplum-db

Eliminate alien nodes before execution for entry db

Open seryozhasmirnov opened this issue 3 years ago • 1 comments

https://github.com/greenplum-db/gpdb/pull/2588 eliminates alien nodes before execution but entry db nodes was missed. This PR adds alien nodes elimination for entry db.

The is a PR https://github.com/arenadata/gpdb/pull/352 in GPDB fork in 6x that also adds test for entry db nodes elimination.

As there is no memory accounting for X_Alien nodes in master alien nodes elimination can be tested manually (i.e. test from https://github.com/greenplum-db/gpdb/pull/2663 is not applicable).

seryozhasmirnov avatar Jul 26 '22 07:07 seryozhasmirnov

Looks good at first glance. Thanks for your contribution.

Please kindly wait for more time and let me and the team look into this.

kainwen avatar Aug 01 '22 03:08 kainwen

@zxuejing @kainwen if all the comments of the PR is addressed, please can we merge the same?

ashwinstar avatar Aug 25 '22 01:08 ashwinstar

@zxuejing @kainwen if all the comments of the PR is addressed, please can we merge the same?

Last night xuejing run a full pipeline for this and decide to push it today based on the ci result.

kainwen avatar Aug 25 '22 01:08 kainwen