Ashwin Agrawal

Seems the PR is not ready as producing wrong result with ORCA (see Chris comment above). Please feel free to re-open or start with fresh version when ready.

> It seems to be a corner case and no persistent impact. > > Not found the issue on master branch. Closing this issue won't fix it for now. Extreme...

Based on all the review comments, it is clear the change is not in an acceptable state. Hence, closing this PR. Great effort and reviews.

Given this PR is not ready and needs more work, closing the same for now. We are tracking to complete this work and will revisit in near future, during that...

Just for reference and keeping context, before commit https://github.com/greenplum-db/gpdb/commit/b52ca70fdfde78d4de0cd31b3a9cf7855c7a7239 SharedLocalSnapshot used to carry subtransaction information as well. Though it used to go stale in some scenarios as mentioned in commit...

> one minor additional work may be to ensure consulting snapshot covering all cases which TransactionIdIsInProgress covered, need to introduce some assertion code (i.e. via slow path TransactionLogFetch ?) to...

@avamingli Please can you help to work with Documentation team to make the enhancement happen to improve the context as mentioned. Thanks.

Sure helpful to backport. Just curious what promoted - did you encounter the invalid page case and any possibility of sharing the scenario and if underlying cause can be fixed...

> This setting allows to make a partial restore of a table or database (for example in https://github.com/wal-g/wal-g). We plan to turn it on for the recovery period and then...

Thanks a lot @nikifkon for all those clarifications - better understand the purpose and usage for this GUC.