gpdb icon indicating copy to clipboard operation
gpdb copied to clipboard

Restore DISTINCT-qualified window aggregates in ORCA

Open x4m opened this issue 3 years ago • 4 comments

Aggregates were disabled by 386d54232, but a lot of fixes were already applied, so maybe it's time to exercise CI against DQWA. May be related to #12641.

x4m avatar May 06 '22 11:05 x4m

Can someone with access to Concourse CI tell me please what went wrong there? Just copy the failed tests...

x4m avatar May 07 '22 06:05 x4m

@x4m olap_window_seq and statement_mem_for_windowagg under orca.

kainwen avatar May 07 '22 07:05 kainwen

Hi, pipeline fails at:

ORCA: olap_window_seq

planner: statement_mem_for_windowagg

kainwen avatar Jul 21 '22 23:07 kainwen

Many thanks kainwen! Is there any way to look in tests by ourselves? In 7x branch concourse-ci is open for pr author...

reshke avatar Jul 22 '22 09:07 reshke

Many thanks kainwen! Is there any way to look in tests by ourselves? In 7x branch concourse-ci is open for pr author...

We don't currently have 6X CI open for public viewing unfortunately. The planner change is likely a flake, but the Orca change is due to a wrong results for the query select dt, pn, count(distinct pn) over (partition by dt), sum(distinct pn) over (partition by dt) from sale; in olap_window_seq

chrishajas avatar Dec 01 '22 21:12 chrishajas

Seems the PR is not ready as producing wrong result with ORCA (see Chris comment above). Please feel free to re-open or start with fresh version when ready.

ashwinstar avatar Jan 09 '23 23:01 ashwinstar