Andrei Shpilenok

> > > @ashpil Have you had time to look at this? Oh wow this is amazing! I somehow completely missed this PR, thanks for pinging me again! Taking a...

Currently panics if such a sequence of commands is run: ``` $ alias nothing= $ nothing ``` If you do the same thing in dash, it just does nothing. Edit:...

Thanks for the debug macro! Can you do convert [this](https://github.com/ashpil/rush/blob/561b6e437593cdf35447c5b979e3da04e0c07f46/src/main.rs#L24) and [this](https://github.com/ashpil/rush/blob/561b6e437593cdf35447c5b979e3da04e0c07f46/src/parser.rs#L323) to `debug_println`, too?

Looking at this, I think to me it might make more sense to do the parsing of the aliased command in the `alias` builtin itself, and have the alias structure...

@emlun With the above comments, I think this PR should be good. Let me know if my comments make sense to you. And, thanks again for implementing this! It looks...

> Thanks for the review! I'll try to fix these things up in the next couple of days. Great! Make sure you rebase against master, as I just did a...

And you can check `alias`/`unalias` in the README! 🎉

> You mean parse the alias immediately when defined? Hmm... maybe? My first thought on that is that it could get weird because aliases can reference each other and include...

Passing in the `Shell` seems reasonable, after all, that's what builtins are for - commands that can't be run by an external program as they must affect the shell directly....

> Okay, here are the changes I ended up with to make that happen. What do you think, should I pull that in here? I think that's better! A couple...