Ashish Kulkarni

Results 151 comments of Ashish Kulkarni

I'm not sure why CI is broken, don't think it's related to your change. I'll try to clean up the CI tomorrow :crossed_fingers:

I still need to get some additional permissions from @darcygarrett so I can't merge #183 right now, hopefully I should get them soon :crossed_fingers:

@mmarusyk I like the idea, but having to specify `prefix: true` for every field doesn't strike me as good. I'd rather have something like ```ruby class Order < ApplicationRecord jsonb_accessor...

@johnnyshields can you update the PR to allow `sassc-embedded` 1.55 and above? That version includes native gems, which will make deployment quite easy.

@johnnyshields thanks, we're using it successfully in Production. I forgot to update my comment :see_no_evil:

See [this code](https://github.com/Vasfed/pronto-github_resolver/blob/0f44fd8bb069118bf96947ab6f013d10e1de28f4/lib/pronto/github_resolver.rb#L58) for something which should work for resolving the comments, since there's no direct API for this.

@d4rky-pl what's the reason you'd want that? It'd mean that all the feedback ends up in one, long comment -- which I don't think makes sense.

@Vasfed I think this is something specific to Gitlab, since #304 implemented it [only for GitHub](https://github.com/prontolabs/pronto/pull/304#discussion_r202537827). I took a look at the `gitlab` gem, and apparently you can only [create...

@arianf happy to accept a PR which implements this.

This should be fixed via 93f4eba2585a84ed26c29c6120a6d2ae37b68b60.