prontolabs
Allow commenting on PR without tying the comment to specific diff and line
Currently, based on Pronto::Github#create_pull_comment the GH integration only allows two types of comments:
- If the
pathandpositionis provided, it creates a review comment for PR - If they are not provided it creates a commit comment
Commit comments are not ideal as they're quite hidden in GitHub UI - they're not displayed in the PR discussion so you need to actively look for them:
It would be great if there was a third ✨ magical ✨ option of creating issue comments via Octokit client.add_comment when building custom runners so message can be displayed prominently in the PR discussion view.
@d4rky-pl what's the reason you'd want that? It'd mean that all the feedback ends up in one, long comment -- which I don't think makes sense.
@ashkulz in our specific case we want to warn developers to update our data redaction script whenever they add any new columns to the database. It's one comment for entire PR, single message, no point in making it complicated. For now the comment is left on the last changed line in schema.rb but having a full comment would be nicer and make it more visible, especially for PRs with other warnings (e.g. rubocop)
[!NOTE]
This feature could also pair great with markdown Alert blocks
I could think of other features that could benefit from this but I guess YMMV, in most cases you can theoretically tie them to specific file/line (e.g. code coverage, repo size increase, dependency update warnings etc.)