Ashitha Santhosh
Ashitha Santhosh
> Was there a reason you didn't use RbacFilter directly? I moved the rbac parsing logic to a common location in io.grpc.xds.internal.rbac.engine package due to following reasons 1. to avoid...
> I think Eric is saying you only need to call [`rbacfilter.buildServerIntercetor()` ](https://github.com/grpc/grpc-java/blob/e939bf6fb89a52e2afc7f830a787f73e58af3807/xds/src/main/java/io/grpc/xds/RbacFilter.java#L171-L193) but yea we have to make `RbacFilter` accessible from auth In non-xDS authorization, we have upto two...
> > This would complicate the API that we expose to the users > > No. Two vs 1 interceptor internally should have no bearing on the API we expose...
@ejona86 Please take a look at the PR when you find time. Thank you:)
@ejona86 Friendly ping!:)
@ejona86 PTAL
@ejona86 PTAL
@ejona86 Thank you for the review. PTAL I resolved all the comments. @YifeiZhuang already approved the PR, should I wait on a final review?