ashishshinde-pubm
ashishshinde-pubm
@bsardo addressed the review comments, please check.
@VeronikaSolovei9 We should call `getNonBidsFromStageOutcomes` only once. We cannot rely on ao.Errors. As per current implementation, we are not capturing the errors (`ao.errors`) but we need to call `getNonBidsFromStageOutcomes` and...
@SyntaxNode , @VeronikaSolovei9 Any updates on this ?
@zhongshixi As per the PRD (https://github.com/prebid/prebid-server/issues/2367) , the seatnonbid are not just related to bid response. Example - SeatNonBid should be constructed for code-204 (Request Blocked - Privacy). Refer -...
@bsardo , @hhhjort , @VeronikaSolovei9 I've resolved the conflcts, Please have a look on this PR.
@bretg , @bsardo Any plan to review this PR ?
Sr No | SEAT NON BID ERROR CODE | PBS Source Code --| -- | -- 1 | 351: Response Rejected - Invalid Creative (Size Not Allowed) |https://github.com/prebid/prebid-server/blob/79422a7542634b356f9c13d7774117f2b818e996/exchange/exchange.go#L1226 | 2...
@SyntaxNode , @bretg , @bsardo please review above table and confirm if locations mentioned under PBS Source Code column are correct for capturing seat non bid scenarios. For point (3)...
Hi @bsardo , For point (3) the bid may get rejected due to any reason (badv/bcat/cattax/battr) that's why I was thinking to provide the generic NBR (350 (Response Rejected -...
As discussed in the bi-weekly meeting, we should return code 356 (Response Rejected - Invalid Creative - Advertiser Blocked) if bid gets rejected due to "badv" field. For other rejection...