Ashish Negi

I have simpler scenario where i want to benchmark operations like `Add` on `ConcurrentDictionary` like collections, parameterizing the number of threads. i.e. how does this collection's a particular operation scale...

Apologies for asking performance problem. I was not aware of it. Is antlr google group only place to ask these kind of questions ? And thanks for giving example for...

with only lexing : ``` func runAntlrParser(q string, b *testing.B) { b.ResetTimer() for i := 0; i < b.N; i++ { input := antlr.NewInputStream(q) lexer := parser.NewGraphQLPMLexer(input) // for only...

@sharwell thanks for looking into this. Here are the benchmarks after applying the [changes](https://github.com/ashishnegi/dgraph/blob/dee53c43c2feb42f4ff280d99c40f42d40ecfd5a/antlr4go/graphqlpm/GraphQLPM.g4). ``` lexing only benchmarks for antlr4 golang target ;; after adding EOF and ErrorCode /query$ gotb...

I ["benchmarked"](https://github.com/ashishnegi/dgraph/blob/bench-antlr4/antlr4go/graphqlpmcpp/GraphQLPM.cpp) one query `nestedquery` (which is taking most of the time) with Cpp target and the numbers are different : Only lexing on `nestedquery` query for 1 million iterations...

@parrt I benchmarked again on `master` of `antlr4` and with `antlr4-4.7.1-*.jar`. ``` ➜ query git:(8ccf5cb) ✗ got -v -bench=QueryParse -run=XXXX BenchmarkQueryParse/spielberg:handwitten:-4 50000 51960 ns/op BenchmarkQueryParse/spielberg:antlr:-4 10000 236041 ns/op BenchmarkQueryParse/tomhanks:handwitten:-4 50000...

In my opinion, Unpin and Pin APIs should be complementary. So, `Unpin` should not be idempotent. Otherwise, it causes source of bugs where we are unpinning a page which was...

In this regard, with `ring consistent hashing` we can also store `ring-key` with the datastore. We can then index on `ring-key`. This will remove full db scan. This will make...

+1 i also see this.

Any suggestions ?