Andrew Shannon Brown

Results 24 issues of Andrew Shannon Brown

Sorry but I couldn't find the answer to this in the readme: Is this the best way to do a self join in squeel? ``` joins { MyClass.as(same_table).on {...} }...

In Viewing

This is very speculative so I'd appreciate if @bigxiang could take a look. You can see my failing test in the pull request. The gist is that this is broken:...

In Viewing

When I receive a review request and I'm the only reviewer, I feel more compulsion to review it quickly. If others are listed as reviewers and I know they have...

pullreminders

I just went through 24 hours without having a PR reviewed and I forgot to remind someone to review my PR. I'm sure they got a reminder but they probably...

pullreminders

I've had to stop using nginx because I was getting a significant number of h13 errors after exactly 5 seconds of service on a request (according to the nginx log)....

This package has the same name as the parent package, which causes go mod not to load this directory or anything alphabetically after it (parser.go, for example).

A rule that requires `noqa` directives to provide an explanation would encourage more readable code. Often when looking at such a directive, it's hard to know why the author has...

rule
needs-decision

Chrome doesn't define standalone attribute on navigator so this doesn't work: From https://github.com/cubiq/add-to-homescreen/blob/f0702feea7d95076f917ebacb61fbfad9f360a07/src/addtohomescreen.js#L166: ``` ruby this.options.mandatory = this.options.mandatory && ( 'standalone' in window.navigator || this.options.debug ); ``` I'd offer a...

This PR uses the singelchecker command from https://pkg.go.dev/golang.org/x/tools/go/analysis#hdr-Standalone_commands to create the standalone command. I was hoping this would give us a config file option but it does not, so I'm...

A bad append could happen in another function. This is probably why it's best to just never initialize a non-empty slice.