backlog
backlog copied to clipboard
pullreminders
As a PR reviewer, I'd like to know if anyone else (name and number of people) was assigned a review
When I receive a review request and I'm the only reviewer, I feel more compulsion to review it quickly. If others are listed as reviewers and I know they have more context than I do, I know I can leave the review to them. I think there is already text that varies based on whether I've been included only as part of a team, but quickly seeing the number of other reviewers and their names (maybe other group names too) would be ideal.
@ashanbrown Would you like this metadata shown on reminders or the real-time notifications, or both?
I was thinking about in a DM but I could imagine it would be generally useful.
On a similar tool I built I'd explicitly tell the user they were the "only" reviewer.
@ashanbrown For DMs, there are two types of notifications – the real-time alerts and the scheduled reminders. I was asking which of these notifications types you'd like the additional context for. Either or both?
Both sounds good. On Mon, Jan 28, 2019 at 5:18 PM Abi Noda [email protected] wrote:
@ashanbrown https://github.com/ashanbrown For DMs, there are two types of notifications – the real-time alerts and the scheduled reminders. I was asking which of these notifications types you'd like the additional context for. Either or both?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pullreminders/backlog/issues/114#issuecomment-458368523, or mute the thread https://github.com/notifications/unsubscribe-auth/ABxZ_q6bmsK0tEsoDE62fymj14IgLw53ks5vH6FXgaJpZM4aW7J3 .
Yeah, that sounds good. It's another thing I'd take into account about whether to review a PR immediately.
On Tue, Jan 29, 2019 at 7:55 AM Abi Noda [email protected] wrote:
Another user requested adding PR size as context to the messages as well.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pullreminders/backlog/issues/114#issuecomment-458593878, or mute the thread https://github.com/notifications/unsubscribe-auth/ABxZ_kv4TXPGqvsDnHsJ5D2-UWaSwTh6ks5vIG7XgaJpZM4aW7J3 .
From another user:
It will be nice to add to this message a bit more info like number of files changed, number of added/deleted/modified raws to give whom ever gets the message a notion on the complexity of the PR. Very small PRs can be reacted almost immediately. Very large PRs can be disregarded almost immediately on a busy period. All the rest can be open for negotiation.