Andrew Shannon Brown

Results 38 comments of Andrew Shannon Brown

On a similar tool I built I'd explicitly tell the user they were the "only" reviewer.

Both sounds good. On Mon, Jan 28, 2019 at 5:18 PM Abi Noda wrote: > @ashanbrown For DMs, there are two types > of notifications – the real-time alerts and...

Yeah, that sounds good. It's another thing I'd take into account about whether to review a PR immediately. On Tue, Jan 29, 2019 at 7:55 AM Abi Noda wrote: >...

We haven't broken out our group reminders by teams/projects so they are so they are currently so prolific as to be useless. I don't see us solving that problem any...

I knew I had read about `/pullreminders`. Looks like I had to reinstall the app to get the feature. I suspect the issue with group reminders is that it requires...

Meant to submit that with my personal account... anyhow, thanks for the response. The reason I wanted to define custom-built column filter is that I really wanted a column to...

Having a way to pass arguments would definitely be my preference, because that would also solve the other problem I have where I want to give a list of columns...

As the author of another golangci-lint integrated linter designed simply to prevent likely, but not necessarily certain, problems (https://github.com/ashanbrown/makezero), I definitely favor the option to have "conservative" linter. That said,...

I didn't realize that we weren't ready to apply `SuggestedFixes`. LMK if I can help.

Thanks for the suggestion. I agree that would work but it doesn't express the intent very obviously and doesn't lend itself to discovery. Might we consider something more direct?