Mikhail Mazurskiy

Results 145 comments of Mikhail Mazurskiy

Having to add `strip_prefix = "."` to `pkg_tar` to preserve the directory structure is really weird.

[ ] `k8s.io/apimachinery/pkg/util/clock` (see https://github.com/kubernetes/kubernetes/issues/94738)

This is still an issue. See https://github.com/ash2k/rules_pkg_bug. ``` $ bazel --version bazel 4.0.0 $ bazel build --verbose_failures --sandbox_debug //:broken_package DEBUG: Rule 'rules_python' indicated that a canonical reproducible form can be...

I've added a new benchmark that exercises the `NewSetWithSortableFiltered()` function directly. Here are the results: ``` main: BenchmarkNewSetWithSortableFiltered-10 8248227 138.4 ns/op 448 B/op 1 allocs/op branch: BenchmarkNewSetWithSortableFiltered-10 6625119 177.0 ns/op...

``` goos: darwin goarch: arm64 pkg: go.opentelemetry.io/otel/attribute Go: 1.21.8 ``` New code: ``` BenchmarkFiltering BenchmarkFiltering/NoFilter BenchmarkFiltering/NoFilter/Set.Filter BenchmarkFiltering/NoFilter/Set.Filter-10 571478235 2.061 ns/op 0 B/op 0 allocs/op BenchmarkFiltering/NoFilter/NewSetWithFiltered BenchmarkFiltering/NoFilter/NewSetWithFiltered-10 1000000 1087 ns/op 3584...

@MrAlias Added back the benchmark.

Just added a unit test to my codebase and it fails: ```go import ( "go.opentelemetry.io/otel/sdk/resource" semconv "go.opentelemetry.io/otel/semconv/v1.12.0" ) func constructResource() (*resource.Resource, error) { return resource.Merge( resource.Default(), resource.NewWithAttributes( semconv.SchemaURL, semconv.ServiceNameKey.String("some name"),...

Perhaps those methods can be moved into the "versioned" packages? They can use the same underlying types, but a matching schema URL from that particular package. In the future more...

I believe we are talking about this field: https://github.com/grpc/grpc-go/blob/v1.58.2/stats/stats.go#L78-L79 I see two approaches: - Nothing in the doc on the field or on the `stats.InPayload` type or on the `stats.Handler`...