utils icon indicating copy to clipboard operation
utils copied to clipboard

pkgs to be moved to utils repo

Open mengqiy opened this issue 8 years ago • 6 comments

These need to move out of k8s in order to cut kubectl out:

  • [x] k8s.io/kubernetes/pkg/util/exec (PR: #5)
  • [ ] k8s.io/kubernetes/pkg/util/interrupt

These should probably live in this repo, but are not required to move:

  • [ ] k8s.io/client-go/util/jsonpath per https://github.com/kubernetes/kubernetes/issues/48209#issuecomment-315483101
  • [ ] apimachinery/pkg/util/sets

Ref: https://github.com/kubernetes/kubernetes/issues/48209#issuecomment-314537745

Feel free to edit the list above if you have more.

mengqiy avatar Jul 18 '17 17:07 mengqiy

We are also using k8s.io/kubernetes/pkg/util/configz in Service Catalog

nilebox avatar Oct 10 '17 04:10 nilebox

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta. /lifecycle stale

fejta-bot avatar Jan 08 '18 05:01 fejta-bot

/remove-lifecycle stale /lifecycle frozen

mengqiy avatar Jan 08 '18 21:01 mengqiy

I find a bunch of pkgs that could be moved to this repo.

  • [ ] https://github.com/kubernetes/kubernetes/tree/master/pkg/util/interrupt
  • [ ] https://github.com/kubernetes/kubernetes/tree/master/pkg/util/filesystem
  • [ ] https://github.com/kubernetes/kubernetes/tree/master/pkg/util/flock
  • [ ] https://github.com/kubernetes/kubernetes/tree/master/pkg/util/hash
  • [ ] https://github.com/kubernetes/kubernetes/tree/master/pkg/util/ipconfig
  • [ ] https://github.com/kubernetes/kubernetes/tree/master/pkg/util/ipset
  • [ ] https://github.com/kubernetes/kubernetes/tree/master/pkg/util/maps
  • [ ] https://github.com/kubernetes/kubernetes/tree/master/pkg/util/netsh
  • [ ] https://github.com/kubernetes/kubernetes/tree/master/pkg/util/slice
  • [ ] https://github.com/kubernetes/kubernetes/tree/master/pkg/util/sysctl
  • [ ] https://github.com/kubernetes/kubernetes/tree/master/pkg/util/tail
  • [ ] https://github.com/kubernetes/client-go/tree/master/util/jsonpath
  • [ ] https://github.com/kubernetes/client-go/tree/master/util/homedir
  • [ ] https://github.com/kubernetes/client-go/tree/master/util/keyutil

@apelisse @thockin WDYT

pigletfly avatar Nov 11 '20 01:11 pigletfly

These look reasonable to me. They're all part of fairly generic package names anyway (pkg/util), so it looks like they are fairly generic. One thing that is important is: are these used in multiple places? are they generally useful or are there some opinions hidden behind these names?

apelisse avatar Nov 19 '20 17:11 apelisse

[ ] k8s.io/apimachinery/pkg/util/clock (see https://github.com/kubernetes/kubernetes/issues/94738)

ash2k avatar Jan 03 '21 00:01 ash2k