Asger F

Results 31 comments of Asger F

Hi, thanks for the clear bug report. I have updated jsnap to use a newer version of phantomjs, which seems to resolve that particular issue. Unfortunately, I haven't updated tscheck...

Thanks for the review @erik-krogh! I have (finally) gotten through the comments and pushed a bunch of fixes. It seems the tests won't work on CI due to changes in...

@erik-krogh some post-merge fixups have appeared after the commit called `Merge branch 'main' into js/shared-dataflow-merged` (they appear prior to our previous comments due to having an earlier commit date).

@erik-krogh after keeping up the CI changes and breaking changes in the data flow library, this PR is finally green again (apart from the QLDoc check which complains about shared...

Merging to the feature branch (not main)

Hi @maschwenk, thanks for the report. If you've seen this on a public repository could you share a link to the repository?

This looks very promising for the JS data flow migration. 🎉 It fixes the four largest regressions we had so far. See [DCA run](https://github.com/github/codeql-dca-main/tree/data/asgerf/shared-dataflow__default__code-scanning__52/reports) showing the effects of cherry-picking this...

Could you say a few words about why the existing `response` threat model is not doing what you want? Is it because you want `local` to enable the threat sources...

> Also, let me know if there's a way to avoid having two DataFlow::SummarizedCallable when all I want to do is change the argument number. I found no way to...

> As a note, I was also unable to use Element, which, according to the [documentation](https://codeql.github.com/docs/codeql-language-guides/customizing-library-models-for-javascript/#access-paths), should select "an element of an array, iterator, or set object." Thanks, I'll make...