Asger F

Results 21 comments of Asger F

After giving this some more thought, I think we can go ahead with this as it is and then refine it if we notice any FPs caused by this.

I've only done a superficial glance at this, but I'd like to talk about the issue with `getACall2`. This is a fundamental issue when using API graphs and flow summaries...

Thanks. Would you mind running a final evaluation? It's a large change and we should reduce the risk as much as possible.

I think we should also restrict it in `TKnownPairValueContent`

Sorry for taking this long getting back to you @franktip. I'm afraid your workaround will have to do. For a while we were considering extracting externs in tests by default,...

Right, adding an option for it would indeed be very useful. I'll re-open the issue, but resolution will unfortunately have to wait until the method for passing options has landed...

> is there any way to inform the codeql test command that we're analyzing code with annotations? Yes, add a file named `options` containing: ``` semmle-extractor-options: --experimental ``` There's an...

Try appending `--exclude lib --exclude node_modules` to the line in the `options` file: ``` semmle-extractor-options: --experimental --exclude lib --exclude node_modules ```

Hm, try `./node_modules/**` and `./lib/**` instead. Sorry, as I mention this extractor interface is being phased out and I don't think we have proper documentation for it. The best reference...

Generalized tear-offs are not supported yet.