Adam Sechrest

Results 59 comments of Adam Sechrest

> > > Thanks for the spacing. Looks much better. I lied about a final comment. @rpherbig notes that this is perhaps the 3rd or 4th place in code where...

> You mean like `$primary_sigils = ["abolition", "congruence", "induction", "permutation", "rarefaction"]` in `common-crafting` at the beginning? Yes, that's my thought. Then we can utilize those globals directly here, in the...

@Dartellum How's this looking? Thanks for adding the sigil globals. I'm showing this PR has conflicts to resolve.

Thanks for the PR. In my opinion this is out of scope for `bput`. We've got some handling for common retries but none that are multi-step, save room numbers, call...

@bwfisher82 It's a good thought. @Raykyn55 asked me the same thing the other day. I think you're both probably right. I find `go2`'s code to be a bit legacy so...

Hmm, I did discover a downside to using `fput`. If you're running `performance`, and you can't don your skates, previous version uses `bput` which handles `stop play` and then retries....

Moving to draft again as I do a final push for full code execution functionality in trigger responses.

Now putting this back to ready for review. The final push of changes does the following: - By convention now, all trigger commands need to be wrapped in curly braces....

> @asechrest I'm on the latest version, and it's great to me. I'm happy to merge this if you are. This sounds good. I also updated the work-in-progress wiki for...

Should we add the new setting to `base.yaml` with a description? After those comments are resolved, this looks good.