dr-scripts icon indicating copy to clipboard operation
dr-scripts copied to clipboard

[script][bescort] - Fix edge case for Ice Road collect rocks

Open asechrest opened this issue 2 years ago • 1 comments

Fixes an edge case where we fail to collect rocks and thus move too quickly.

Prior behavior would not pause if we somehow failed to collect rocks. This could be because your hands were full, ~~or you were playing an instrument~~, etc. This change favors a brute-force fput('collect rock'), and then detecting whether we're in RT. If so, we're collecting and we kick the pile and move on. If not, it pauses 15 (the same duration as a collect), so that we don't move quickly and get injured.

asechrest avatar Sep 04 '22 14:09 asechrest

Hmm, I did discover a downside to using fput. If you're running performance, and you can't don your skates, previous version uses bput which handles stop play and then retries. fput doesn't have such handling, so if you're playing an instrument it won't successfully collect, but it will pause 15.

asechrest avatar Sep 04 '22 16:09 asechrest

@asechrest @MahtraDR

Is this still in progress or ready for review? If you don't intend to continue with it please close it out.

Thanks!

Kiriawen avatar Jan 16 '23 04:01 Kiriawen