Mahdi Ali-Raihan
Mahdi Ali-Raihan
Hi @sunshowers, whenever you are able to, could you take a look at this PR in introducing profile inheritance? The inheritance cycle detection is a little bit verbose due to...
Isn't it possible for there to be a self referential SCC if the user sets the inherits to the current profile?
I think I'm having a hard time finding out on how to do this in a neat and efficient manner. Earlier, I wanted to use `remove_node()` to get rid of...
I appreciate the advice and I agree with your properties and error handling here (didn't think about the error collector pattern!). I have a couple of follow up questions to...
@sunshowers, I modified the code to follow the properties we talked about earlier and added a couple of test cases. Let me know if there's anything I should change or...
Took your suggestions and modularized the `check_inheritance_cycles()` (now called `custom_profile_inheritances()`; there's a separate `check_inheritance_cycles()` function that fits the purpose of the name) into a few smaller functions for neatness. I...
It's all good and no pressure or rush in checking this out.
Okay sweet, it's nice to see that this got merged in. Thank you for the opportunity on letting me work on this issue!
I just noticed there was already a PR created to resolve the inherits issue. Is it alright if I continue with this @zokhcat @sunshowers?
Wow, this looks awesome to see a highly optimized version of the factor command. I won't have time to look at it today (most likely tomorrow afternoon), but this is...