Andrew Jones

I needed this, but looks like at least 1. already works. This commit seems to be it: https://github.com/simonmichael/hledger/commit/fdc507bd1365a98a145f94a48ce7c887b1c1dc7c

I would add that there are potentially benefits to removing some abstractions required for the offchain env in the `ink!` codebase. It would certainly remove a lot of code, and...

As an experiment I [crudely removed](https://github.com/paritytech/ink/commit/696b9ef03d45b429b7f4be8129787b5e8aba2362) the topics codegen, which reduced `erc20` based on https://github.com/paritytech/ink/pull/946 from `12.0KB` to `9.9KB`. As a comparison with all calls to `emit_event` commented out, we...

A promising [experiment](https://github.com/paritytech/ink/compare/aj-events-refs?expand=1): I managed to get `8.0K` (down from `11.0K`) from the latest `master` with making everything a reference: ``` /// Event emitted when a token transfer occurs. #[ink(event)]...

No, I needed to remove the `Decode` requirements and add a bunch of lifetimes everywhere: I'm sure they could be reduced but I wanted just to prove the possible gains.

> A promising experiment: I managed to get 8.0K (down from 11.0K) from the latest master with making everything a reference: This is unfortunately wrong. The correct number is `10.3K`...

It's because `FixedU128` does not implement `TypeInfo`. As it happens I am currently working on a PR which adds `TypeInfo` impls to this and many other substrate primitives. https://github.com/paritytech/substrate/pull/8615.

> 1. The identifier of the event is generated based on the name of the contract's storage. > https://github.com/paritytech/ink/issues/1222 during retreat solves that very well. The name of the events...

> Also, you implemented emitting of those events in that crate. Okay I had not considered this scenario, my assumption was that the contract implementation itself would always raise the...

Will respond properly tomorrow but regarding: > 2. It doesn't solve the issue described in the example with Dex::swap and emitted PSP22::Transfer events. It is because we didn't pull the...