Ashley Scillitoe
Ashley Scillitoe
@RobertSamoilescu I've attempted to fix the problem with the docs CI failing. It was due to the $f_S(x_{S})$ equation in `PartialDependence.ipynb`. There were a number of minor issues: - The...
P.s. It seems there is still an issue with the hyperlink format I advised you to use. I'll look into this now.
> P.s. It seems there is still an issue with the hyperlink format I advised you to use. I'll look into this now. @RobertSamoilescu you are doing everything correct here....
I agree, `target_fn` seems like a really nice option. The similarity with `preprocess_fn` in `alibi-detect` means we can of course reuse lots of the functionality between the two libraries, but...
Brief note re using a `catalogue` type function registry for `target_fn`, we will need to think about whether we want the explainers themselves to accept registry strings and resolve to...
Not related to `beartype`, but on the subject of `autodoc`, mocked modules, decorators etc I also had trouble with documenting `torch.jit.script` decorated functions in `alibi-detect`. Lines 319-332 in [conf.py](https://github.com/SeldonIO/alibi-detect/blob/45c4670c1974e4b368e74b189e0a9ba69371ea8d/doc/source/conf.py) were...
My Fortran upbringing pushes me towards option 2, I still can't help writing `a=42.` etc instead of `a=42`! I take your point though that breaking changes aren't ideal...
@jklaise agreed on all points above. As much as it would be nice to lead the way on being more strict on `float` vs `int` here, the "un-pythonic" nature of...
@mauicv I imagine you've already tried lots of this, but some things I can think to try based on a similar experience with `alibi-detect` are: 1. Save an explainer. Then...
Yeh agreed, the differences are very very small so not a high priority issue!