Aiden Scandella

Cool! So uh... is there something we can document here to help others, or was this just something specifically broken about your setup?

Oh, that's not good, we definetely need to provide better documentation and error messages around that.

See #156 for previous discussion. We'd love to support Jenkinsfile! I have never used it and don't have the bandwidth to work on it. If there's anybody in the community...

Great point, we actually have the same issue at Uber occasionally. There are two ways to implement this, and either would be relatively simple, but the plugin is more or...

That does, indeed, sound like a bug.

Yes, it currently assumes you are passing the SHA as another parameter and configuring your SCM plugin to pull the correct SHA. We need some documentation on how this is...

This is how I set up my test install to verify the functionality:  And then in jenkins, you add a string parameter for `SHA` and tell the git plugin...

Have you unchecked the "comment with console link on failure" configuration option? https://github.com/uber/phabricator-jenkins-plugin/blob/master/docs/configure-job-post-build.png

Aborted is different than failed. Last I checked (and the whole reason I added that checkbox option in the first place) was for this exact scenario -- if you'd like...

Yes, agreed that "unstable" is treated differently than "failed" and that the failed build checkbox option partially solves your problem. The question now is whether we want to add an...