phabricator-jenkins-plugin icon indicating copy to clipboard operation
phabricator-jenkins-plugin copied to clipboard

Published 20 hours ago • verified publisher icon uber

Plugin doesn't use the commit sha1 in phid for non-differential builds - Update docs

Open ChaitanyaPramod opened this issue 8 years ago • 3 comments

This is evidenced here: https://github.com/uber/phabricator-jenkins-plugin/blob/master/src/main/java/com/uber/jenkins/phabricator/PhabricatorBuildWrapper.java#L87

ChaitanyaPramod avatar Feb 26 '16 19:02 ChaitanyaPramod

Yes, it currently assumes you are passing the SHA as another parameter and configuring your SCM plugin to pull the correct SHA. We need some documentation on how this is supposed to be configured, and if possible we should fetch commit metadata and reset to that.

ascandella avatar Feb 26 '16 19:02 ascandella

Whoa! didn't know that. Will configure SHA parameter. Does the PHID contain the commit SHA1?

(Thanks for the ultra-quick response)

ChaitanyaPramod avatar Feb 26 '16 19:02 ChaitanyaPramod

This is how I set up my test install to verify the functionality:

image

And then in jenkins, you add a string parameter for SHA and tell the git plugin to check out that sha

ascandella avatar Feb 26 '16 21:02 ascandella