Andrew Sauber

Results 33 comments of Andrew Sauber

I had a copy of the Makefile that removed all ambiguity, but it got lost in my stash. I'll add a to-do item for myself to put up a PR.

Rather than document this, maybe we should change this arg to use `nargs='*'` which has better behavior

This has been on my personal to do list for a while. Thanks for codifying it

Google Drive support would be great! I would switch all my note-taking to Boostnote.

Hi @ronneke1996, I'll pick this up.

Some example PRs from recent large-size change sets: https://github.com/cilium/cilium/pull/32336/commits https://github.com/cilium/cilium/pull/32125/commits In these case I believe the reviewers also held some conversations to explain the changes to the reviewers.

@tommyp1ckles no related cilium-cli changes. This is intended to make the `clustermesh enable` command work as documented.

@Zarkonnen This is failing the build because of Sauce creds. Would be interested to see if it passes otherwise.

This would be a huge help for getting the expected upgrade behavior when using `--set`. Can we merge this?

Thanks for the PR! Glad to see that you got some value out of the concept. I would prefer to keep this with as few external dependencies as possible, so...