Ahmed Ashour

Results 72 comments of Ahmed Ashour

To make a minimal case: 1. Clone/fork flutter (`packages/flutter` is used below) 2. In Flutter, replace `lib/fix_data.yaml` with fix_data.yaml ```yaml version: 1 transforms: - title: 'Replace with C_new' date: 2022-10-07...

@bernaferrari your case works. Make sure you don't have the test class inside Flutter `master` project, because it [ignores](https://github.com/flutter/flutter/blob/23f22cb8535c0e8746badef943c8c178d30b5f07/analysis_options.yaml#L25) `@deprecation`, which is required to produce an `error`, which is required...

https://dart-review.googlesource.com/c/sdk/+/263260 When a parameter is deprecated, `replacedBy` was changing the argument instead of changing the constructor.

https://dart-review.googlesource.com/c/sdk/+/259701 Handling `ARGUMENT_TYPE_NOT_ASSIGNABLE`

https://dart-review.googlesource.com/c/sdk/+/260111

https://dart-review.googlesource.com/c/sdk/+/263741

Duplicate of #49561, but this has feedback.

Thanks for hinting, I would change the description more, but I guess the intention is something else, the return statement can directly return a value (e.g. `1`) instead of `Future.value(1);`...

https://dart-review.googlesource.com/c/sdk/+/260581

The current implementation checks for `lib/fix_data` folder, then is recursively process all files under that folder. In the PR, the folder is `lib/src/fix_data`, let me know if we need to...