Ahmed Ashour

Results 72 comments of Ahmed Ashour

https://dart-review.googlesource.com/c/sdk/+/260109 changes the range of dead code of the RHS of binary operator

https://dart-review.googlesource.com/c/sdk/+/260110 handles `do` statement as two separate regions (one for `do`, another for `while`), and correcting the quick fix.

~~1. For removing the following statements after the `do while`, please see [sdk/263900](https://dart-review.googlesource.com/c/sdk/+/263900)~~ 2. There is a currently a [failing test](https://github.com/dart-lang/sdk/blob/a1b669fda1e238845784edebfc859d1cc57cba6f/pkg/analysis_server/test/src/services/correction/fix/remove_dead_code_test.dart#L106-L122), which points to this issue of the scenario: ```dart...

https://dart-review.googlesource.com/c/sdk/+/263940 for the first part in OP.

https://dart-review.googlesource.com/c/sdk/+/266388 which is similar to https://github.com/dart-lang/sdk/commit/931961eac8d38df12f14a6d8b945c4c4840d2979. `MethodInvocation` was missed, because I incorrectly locally tested it as a `Statement`, not as an `Expression`.

https://dart-review.googlesource.com/c/sdk/+/266389 which handles updaters` of `forParts`. This CL fixes this issue, as it removes the previously failing tests referencing it. Please note that there is a new failing test, because...

**Update:** the test case below passes when the error offset is changed. Sorry for the disturbance. After writing the first comment, and investigating further, there are some results which made...

The reason seems to be that Flutter [disables](https://github.com/flutter/flutter/blob/463ee3d58ccf089c92e3c51d302b2796b9d43a66/analysis_options.yaml#L25) deprecation errors, and so `dart fix` doesn't find any relevant fixes. For the time being, this can be handled by temporarily removing...

https://dart-review.googlesource.com/c/sdk/+/260761 Thanks for the explanation. On looking on the PR, I thought that the fix was applied before the commit, so the "old" class and constructor were existing and are...

The [commit](https://github.com/dart-lang/sdk/commit/8eb8e61e1ee79910322210f8eabb3b67a443855a) seems to be available since [2.19.0-262.0.dev](https://github.com/dart-lang/sdk/releases/tag/2.19.0-262.0.dev) (as shown in its tags). The change was handling the case where the the `old` (`BoxDecoration` in this case) doesn't exist at...