Aliaksei Sapach
Aliaksei Sapach
I think your workaround is the only way to address the issue. I don't think I can do anything in the transformation that would prevent the code in the module...
In our team we've created an abstraction layer on top of the plugin that looks something like this: ```js import * as foo from './foo.js'; injector.rewire(foo, bar); ... injector.restore(); ```...
Here you go: https://gist.github.com/asapach/9f4ee23583f130e9a16b540f31cbfd93 I didn't include the support for named exports just to keep it simple, but it's trivial to add by using ``module[`rewire$${exportName}`]`` instead of `module.rewire`.
I would definitely rather split these into multiple PRs.
> Fair enough. So I take it your main concern is the search feature and relying on third parties, while the other changes are ok? I'll need to review them,...
If the video is in MP4 (or other HTML5-compatible format like WebM or Theora), the browser will open the built-in video player - you don't need a plugin for those....
Never used netlify. Are there any logs or error messages?
From what I can tell it failed to initialize, because the socket.io endpoint is not working: https://gracious-morse-b7d258.netlify.com/socket.io/socket.io.js returns 404.
And in general the whole backend is not working: https://gracious-morse-b7d258.netlify.com/torrents/ Just the static files.
I can see that it's running the build, but I don't see it starting the actual application, e.g `npm start`.