Yoann Padioleau
Yoann Padioleau
Ok so I've implemented the semgrep-core side of that. Bad rules are now filtered and returned in a new skipped_rules field in the JSON. What remains is to use this...
Is it still the case @IagoAbal ? Can we close the issue?
Well you can do that: https://semgrep.dev/s/oZ81 I think pattern-param: is a not a great idea because I actually want to get away from all those pattern-xxx: and generalize instead.
maybe we could allow a pattern like ',Search $S,' to indicate we're looking for a parameter. We also have a similar problem when someone is looking for a type where...
In OCaml I require to have ':' in front of MyType, as in ': MyType' so it's clear you're looking for MyType in a typing context.
Looks great! I've requested changes, but it's mostly for adding more comments in the .mli so the whole thing is clearer by just looking at the types and the comments...
I don't feel strongly. I'm fine with your design choices, I just wanted to point out alternatives (and maybe ask you to explain more those alternatives in comments and how...
probably need to merge develop for fixing the pytest regressions.
Merged!