Yoann Padioleau comments

Results 358 comments of


                                            Yoann Padioleau

semgrep-core linked to homebrew libpcre.1.dylib

@spencerdrak can you have a look? I think you recently had a fix regarding homebrew. Is it related?

False positives when matching strings that start with a backtick

@mjambon is it related to the other recent bug with generic mode?

Semgrep won't scan files that don't end with the right extension

yeah @emjin , first bug report for yaml!

Lack of trailing newline masks Ruby parse errors

Weird. @mjambon any idea why tree-sitter has a different behavior with or without a trailing newline?

Lack of trailing newline masks Ruby parse errors

Nice matt. Learning a new thing about tree-sitter every week :)

Lack of trailing newline masks Ruby parse errors

We can probably add this MISSING token with a fake token in the CST and AST.

Lack of trailing newline masks Ruby parse errors

Another example from @emjin : https://semgrep.dev/s/emjin:rescue if you add an extra newline at the end, you get the parse error, otherwise no.

Lack of trailing newline masks Ruby parse errors

This bite us again today with emma. Would be nice to find a fix.

Lack of trailing newline masks Ruby parse errors

still an issue @mjambon

[RFC] Add minimum semgrep version needed to run rule

[pad](https://app.slack.com/team/UJHBTQ3MH) [4 minutes ago](https://returntocorp.slack.com/archives/C01NXGX2EHZ/p1647532160180069?thread_ts=1647532020.618589&cid=C01NXGX2EHZ) sounds good to me! [pad](https://app.slack.com/team/UJHBTQ3MH) [4 minutes ago](https://returntocorp.slack.com/archives/C01NXGX2EHZ/p1647532184981439?thread_ts=1647532020.618589&cid=C01NXGX2EHZ) let’s handle it mostly python side for now, to keep it simple [pad](https://app.slack.com/team/UJHBTQ3MH) [4 minutes ago](https://returntocorp.slack.com/archives/C01NXGX2EHZ/p1647532201978509?thread_ts=1647532020.618589&cid=C01NXGX2EHZ) (we will...